fix(locale): restore {{user}} placeholder in Spanish email greetings - #13637
Open
owgreen-dev wants to merge 1 commit into
Open
fix(locale): restore {{user}} placeholder in Spanish email greetings#13637owgreen-dev wants to merge 1 commit into
owgreen-dev wants to merge 1 commit into
Conversation
Five Spanish email greetings drop or mangle the {{user}} placeholder:
verification/recovery used {{name}} (never passed by the template, so they render
"Hola, ."), and magicSession/otpSession/invitation dropped it entirely ("Hola,").
Aligns them with the English source and the existing emails.sessionAlert.hello.
Contributor
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Several Spanish transactional-email greetings drop or mangle the
{{user}}placeholder inapp/config/locale/translations/es.json, so the emails render an empty or incorrect greeting.emails.verification.helloandemails.recovery.hello:"Hola, {{name}}.,"—{{user}}was replaced with{{name}}, which the templates never pass (the variable isuser, e.g.'user' => $user->getAttribute('name')), so these render "Hola, ." to users.emails.magicSession.hello,emails.otpSession.hello,emails.invitation.hello:"Hola,"—{{user}}dropped entirely, so the greeting is an anonymous "Hola,".The English source is
"Hello {{user}},"for all five, and the repo's ownemails.sessionAlert.helloalready uses the correct Spanish form"Hola {{user}},". This PR aligns the five broken greetings with it.Fix (values only, 5 lines)
emails.verification.helloHola, {{name}}.,Hola {{user}},emails.recovery.helloHola, {{name}}.,Hola {{user}},emails.magicSession.helloHola,Hola {{user}},emails.otpSession.helloHola,Hola {{user}},emails.invitation.helloHola,Hola {{user}},Found while testing an open-source i18n placeholder checker; verified against
main.