🔄 PHP-Retry Summary

Flaky tests detected across commits:

Greptile Summary

This PR fixes a server error that occurred when deleting a file whose chunked upload was cancelled before any bytes were written to disk. The root cause was that abort() on the Local storage device throws \Exception when the temporary chunk directory doesn't exist, and that exception propagated uncaught — leaving the pending DB document behind.

The fix wraps the abort() call in a try/catch (\Exception) so that a missing-chunks-on-disk scenario is treated as a clean deletion, allowing the DB document to be removed normally. A dedicated e2e test (testDeletePartiallyUploadedFile) validates the happy path by uploading only the first chunk of a multi-chunk file and asserting that the resulting pending file can be deleted successfully.

Key points:

• The Local storage abort() implementation only throws \Exception for a missing directory, so the catch is correct for that adapter.
• The catch (\Exception) is broad and will also swallow exceptions from cloud storage adapters (S3, B2, etc.) that may throw for transient reasons (network, credentials), potentially orphaning partial upload data on those providers without any log trace.
• The new test does not clean up the bucket it creates, and uses error-suppressing @ operators for file I/O that could produce confusing failures if the test resource is ever missing.

Confidence Score: 4/5

Safe to merge for Local storage deployments; the broad exception catch warrants a follow-up for cloud storage adapters but is not a blocker.

The core fix is correct and well-targeted for the described bug. The exception type thrown by the Local device (\Exception) matches what is caught. The e2e test exercises the fixed path end-to-end. The one concrete concern — that catch (\Exception) silently swallows unexpected errors from cloud storage adapters — is a real edge case but not likely to cause problems in normal usage for the majority of deployments. P2 test hygiene issues do not affect merge safety.

src/Appwrite/Platform/Modules/Storage/Http/Buckets/Files/Delete.php — review the exception catch breadth if cloud storage adapters are a primary concern.

Important Files Changed

_{Reviews (1): Last reviewed commit: "fix: allow deletion of partially-uploade..." | Re-trigger Greptile}

✨ Benchmark results

• Requests per second: 1,461
• Requests with 200 status code: 263,067
• P99 latency: 0.121484195

⚡ Benchmark Comparison

@copilot Address two reviews above, I pinged you in both

@copilot Address two reviews above, I pinged you in both

Done in ecc76c7:

• Delete.php: Inject Log $log, capture exception as $e, and call $log->addTag('abortException', $e->getMessage()) so unexpected failures surface in structured logs.
• StorageBase.php: Removed @ error-suppression operators (added assertNotFalse on the file handle), and added bucket deletion at the end of testDeletePartiallyUploadedFile for proper cleanup.