feat: migrate to utopia-php/database query-lib#11649
Draft
feat: migrate to utopia-php/database query-lib#11649
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✨ Benchmark results
⚡ Benchmark Comparison
|
|
Found 128 test failures on Blacksmith runners: Failures
|
🔄 PHP-Retry SummaryThe number of flaky tests is too large to display in a single comment. |
abnegate
force-pushed
the
feat-query-lib
branch
from
d6bbf3f to
8280bda
Compare
…, worker.php, cli.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Database::VAR_*,INDEX_*,PERMISSION_*,RELATION_*string constants with typed enums (ColumnType,IndexType,PermissionType,RelationType,ForeignKeyAction,RelationSide)getSupportFor*()adapter methods withinstanceof Feature\*and$adapter->supports(Capability::*)createAttribute(),createIndex(),createRelationship()worker calls to useAttribute,Index,Relationshipvalue objectsaddHook()registration for all database hooks (Permissions,Tenancy,Relationships,Decorator,Lifecycle)->on()closures to typedLifecyclehooksMetadatadecorator hook to replaceprocessDocument()recursion in all document CRUD endpointsprocessDocument(),checkPermissions(),prepareRelationships()closures from endpointsAttribute/Indexvalue objects (~3000 lines removed)createAttributesFromCollection()bug (raw arrays passed to method expectingAttributeobjects)Test plan
testAggregateCount,testAggregateSum,testAggregateAvg,testAggregateMinMax,testGroupBy,testGroupByWithHaving,testDistinct,testCountDistinct,testAggregateWithFiltertestJoin,testLeftJoin,testJoinWithAggregationtestJoinDeniedWithoutCollectionPermission,testJoinRespectsDocumentPermissions,testJoinWithApiKeyBypassesDocumentPermissions,testJoinToNonexistentCollection🤖 Generated with Claude Code