Open
Conversation
Contributor
📝 WalkthroughWalkthroughUpdated Dockerfile base stage image from appwrite/base:0.11.5 to appwrite/base:1.0.0. Modified app/controllers/general.php to treat certain headers as single-value (content-length, content-type) and replace those when applying header overrides while preserving prior append behavior for other headers. Updated composer.json to require utopia-php/websocket 1.0.* (was 0.3.*). Removed runtime file-length equality checks for generated PNGs in tests/e2e/Services/Avatars/AvatarsBase.php. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Security Scan Results for PRDocker Image Scan Results🎉 No vulnerabilities found! Source Code Scan Results🎉 No vulnerabilities found! |
✨ Benchmark results
⚡ Benchmark Comparison
|
abnegate
force-pushed
the
feat-update-base
branch
from
57ab09c to
1e22a40
Compare
- Update utopia-php/migration to 1.5.1 (fixes duplicate header issue) - Fix content-length header override to replace instead of append - Single-value headers (content-length, content-type) must replace existing values - Multi-value headers continue to use array semantics Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Temporarily use dev branch (fix-conditional-compression) that only applies SWOOLE_WEBSOCKET_FLAG_COMPRESS when compression is enabled. This fixes websocket compatibility issues with Swoole 6.1.6. See: utopia-php/websocket#28 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@composer.json`:
- Around line 12-17: Update composer.json to avoid using the floating branch
reference for utopia-php/websocket: replace the unpinned
"dev-fix-conditional-compression" repository usage for package
"utopia-php/websocket" with a commit-pinned requirement (e.g., use the dev
branch with #<commit-sha> suffix in the package version) so builds are
reproducible, and add a short tracking comment near that requirement indicating
this is a temporary pin tied to the upstream PR (`#28` /
dev-fix-conditional-compression) so it can be reverted when a stable release or
merged commit is available.
The PNG file size varies depending on ImageMagick version and compression settings. The meaningful validations (dimensions, format, content-type) are already being tested. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist