Skip to content

fix: default namespace in sdks#11031

Merged
ChiragAgg5k merged 1 commit into1.8.xfrom
fix-default-namespace-in-sdks
Dec 28, 2025
Merged

fix: default namespace in sdks#11031
ChiragAgg5k merged 1 commit into1.8.xfrom
fix-default-namespace-in-sdks

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

@ChiragAgg5k ChiragAgg5k commented Dec 28, 2025

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 28, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The changes add namespace configuration support to SDK generation. A new namespace field with value io.appwrite is introduced in the SDK configuration file for Android and Kotlin SDKs. The SDK generation logic is updated to dynamically read the namespace from the language configuration instead of using a hardcoded value, with appwrite as the default fallback when namespace is not specified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive No pull request description was provided by the author, so this check cannot evaluate whether the description is related to the changeset. Add a pull request description that explains the purpose of making namespace configurable, the problem it solves, and any relevant context for reviewers.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: default namespace in sdks' accurately describes the main change: making namespace configurable with a default fallback in SDK generation.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-default-namespace-in-sdks
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d02554 and 77930a0.

📒 Files selected for processing (2)
  • app/config/sdks.php
  • src/Appwrite/Platform/Tasks/SDKs.php
🧰 Additional context used
🧬 Code graph analysis (1)
src/Appwrite/Platform/Tasks/SDKs.php (1)
src/Appwrite/SDK/Method.php (1)
  • setNamespace (226-230)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan
🔇 Additional comments (2)
app/config/sdks.php (1)

119-119: LGTM! Namespace additions align with Maven artifact group IDs.

The namespace field 'io.appwrite' has been correctly added to both Android (line 119) and Kotlin (line 399) SDK configurations. This is consistent with:

  1. Java/Kotlin package naming conventions (reverse domain notation)
  2. The Maven artifact group IDs shown in the package URLs for both SDKs
  3. Standard practice for JVM-based SDK package organization

The consistency between both SDKs is good, and the format follows established conventions.

Also applies to: 399-399

src/Appwrite/Platform/Tasks/SDKs.php (1)

382-382: Verify the intentionality of the default namespace value.

The namespace now defaults to 'appwrite' when not specified in the language configuration. Only Android and Kotlin SDKs currently have explicit namespace values ('io.appwrite' in the config). This raises a question about whether the default should align with the explicit values or whether the format difference is intentional for language-specific conventions (Java packages typically use reverse domain notation like io.appwrite, while other languages may prefer simpler formats like appwrite).

Clarify: Is the different format ('appwrite' default vs. 'io.appwrite' explicit) intentional based on SDK language conventions, or should the default be 'io.appwrite' for consistency?

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 28, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libpng 1.6.51-r0 CVE-2025-66293 HIGH
libpng-dev 1.6.51-r0 CVE-2025-66293 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@ChiragAgg5k ChiragAgg5k merged commit 834c18f into 1.8.x Dec 28, 2025
41 of 42 checks passed
@ChiragAgg5k ChiragAgg5k deleted the fix-default-namespace-in-sdks branch December 28, 2025 15:20
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 28, 2025

✨ Benchmark results

  • Requests per second: 1,180
  • Requests with 200 status code: 212,523
  • P99 latency: 0.164928222

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,180 1,236
200 212,523 222,616
P99 0.164928222 0.167353311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loks0n loks0n loks0n approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChiragAgg5k @loks0n