Skip to content

Fix: deletes bug#10965

Merged
abnegate merged 1 commit into1.8.xfrom
fix-deletes-bug
Dec 16, 2025
Merged

Fix: deletes bug#10965
abnegate merged 1 commit into1.8.xfrom
fix-deletes-bug

Conversation

@Meldiron
Copy link
Copy Markdown
Contributor

@Meldiron Meldiron commented Dec 16, 2025

What does this PR do?

While working on different feature, noticed this:

image

This PR fixes it. It was the only such error I could find in deletes worker.

Test Plan

None

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 16, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The deleteOldCSVExports method in the Deletes worker has been modified to pass a plain string '.csv' to the endsWith predicate instead of an array containing a single element ['.csv']. This changes the argument type from an array to a string while maintaining the same filtering logic for identifying CSV files to be deleted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify endsWith behavior: Confirm how the endsWith function handles string vs. array arguments to ensure the behavior remains consistent
  • Check method signature: Review the endsWith method definition to understand parameter expectations and validate the change is compatible
  • Test impact: Ensure CSV file filtering still operates correctly with the modified argument type

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix: deletes bug' is vague and does not clearly describe the specific change made. While it relates to the changeset, it lacks specificity about what bug was fixed. Provide a more specific title that describes the actual fix, such as 'Fix: correct endsWith argument type in CSV export cleanup' to make the change immediately clear to reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, mentioning an error found in the deletes worker that the PR fixes, though it relies on an image that may not be clearly descriptive.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-deletes-bug

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Dec 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ba970b and 1f4534d.

📒 Files selected for processing (1)
  • src/Appwrite/Platform/Workers/Deletes.php (1 hunks)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 16, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libpng 1.6.51-r0 CVE-2025-66293 HIGH
libpng-dev 1.6.51-r0 CVE-2025-66293 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@abnegate abnegate merged commit dfccbd0 into 1.8.x Dec 16, 2025
30 of 45 checks passed
@abnegate abnegate deleted the fix-deletes-bug branch December 16, 2025 09:57
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 16, 2025

✨ Benchmark results

  • Requests per second: 1,221
  • Requests with 200 status code: 219,772
  • P99 latency: 0.162079521

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,221 1,241
200 219,772 223,512
P99 0.162079521 0.162847152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@abnegate abnegate abnegate approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Meldiron @abnegate