src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Attribute/Increment.php (1)

172-181: Verify transaction-staging response uses the same $collectionId / $tableId key as the non-transaction response (and consider centralizing).

The new '$' . $this->getCollectionsEventsContext() . 'Id' attribute (Line 180) looks correct for the normal path, but the transactionId early-return path builds $mockDocument with '$' . $groupId (Line 159-165). Please confirm getGroupId() resolves to the same key (collectionId vs tableId) so staged vs non-staged responses don’t diverge. Also, this attribute-setting is duplicated in Decrement—consider a small helper to set it in one place.

tests/e2e/Services/Databases/Legacy/DatabasesBase.php (2)

6115-6122: Add an explicit key-presence assertion for clearer failures (increment response).
If '$collectionId' is missing, PHP array access can produce noisy notices and the failure message is less actionable; asserting presence first makes the test output cleaner.

         $this->assertEquals(200, $inc['headers']['status-code']);
         $this->assertEquals(6, $inc['body']['count']);
-        $this->assertEquals($collectionId, $inc['body']['$collectionId']);
+        $this->assertArrayHasKey('$collectionId', $inc['body']);
+        $this->assertEquals($collectionId, $inc['body']['$collectionId']);

---

6226-6234: Add an explicit key-presence assertion for clearer failures (decrement response).
Same rationale as increment: validate the response shape before asserting equality.

         $this->assertEquals(200, $dec['headers']['status-code']);
         $this->assertEquals(9, $dec['body']['count']);
-        $this->assertEquals($collectionId, $dec['body']['$collectionId']);
+        $this->assertArrayHasKey('$collectionId', $dec['body']);
+        $this->assertEquals($collectionId, $dec['body']['$collectionId']);

tests/e2e/Services/Databases/TablesDB/DatabasesBase.php (1)

7874-7877: Good coverage: validates $tableId is echoed in decrement response.
Optional: also assert $tableId on $inc2 / $dec2 to cover the non-default value paths.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: ItzNotABug
Repo: appwrite/appwrite PR: 9693
File: src/Appwrite/Platform/Modules/Databases/Http/Databases/Tables/Update.php:57-59
Timestamp: 2025-06-19T09:20:03.312Z
Learning: In table-related endpoints (such as `src/Appwrite/Platform/Modules/Databases/Http/Databases/Tables/Update.php`), parameter descriptions should use "table" and "row" terminology instead of "collection" and "document" for clarity and consistency.