Skip to content

Fix: remove temp queries#10928

Merged
lohanidamodar merged 2 commits into1.8.xfrom
fix-remove-temp-fix
Dec 10, 2025
Merged

Fix: remove temp queries#10928
lohanidamodar merged 2 commits into1.8.xfrom
fix-remove-temp-fix

Conversation

@lohanidamodar
Copy link
Copy Markdown
Member

What does this PR do?

  • remove temp queries

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 10, 2025

📝 Walkthrough

Walkthrough

This pull request removes temporary hard-coded log-filtering blocks that appended an OR condition on createdAt (a fixed date range in February 2025) across multiple files. The deletions occur in several API controllers (account, messaging, teams, users) and multiple database/log listing modules. No new filtering, signature, or error-handling changes are introduced; log queries will now rely solely on caller-provided/parsed queries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Homogeneous changes: repeated removal of the same temporary date-range filter across files.
  • Low per-file complexity: each edit is a straightforward deletion with no added logic.
  • Review focus:
    • Ensure no remaining references to the removed date constants or orphaned imports.
    • Verify tests or code paths that relied on that temporary filter are updated or intentionally left broader.
    • Spot-check a couple of affected endpoints (one API controller and one DB module) to confirm query construction still behaves as expected.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix: remove temp queries' directly corresponds to the changeset, which removes temporary date-range query filters across multiple API controllers and database modules.
Description check ✅ Passed The description states 'remove temp queries,' which aligns with the changeset that removes temporary hardcoded log filters and date-range constraints from multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-remove-temp-fix

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61067bd and 4c9a94f.

📒 Files selected for processing (4)
  • src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Logs/XList.php (0 hunks)
  • src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Logs/XList.php (0 hunks)
  • src/Appwrite/Platform/Modules/Databases/Http/Databases/Logs/XList.php (0 hunks)
  • src/Appwrite/Platform/Modules/Databases/Http/TablesDB/Logs/XList.php (0 hunks)
💤 Files with no reviewable changes (4)
  • src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Logs/XList.php
  • src/Appwrite/Platform/Modules/Databases/Http/TablesDB/Logs/XList.php
  • src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Logs/XList.php
  • src/Appwrite/Platform/Modules/Databases/Http/Databases/Logs/XList.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 10, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libpng 1.6.51-r0 CVE-2025-66293 HIGH
libpng-dev 1.6.51-r0 CVE-2025-66293 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 10, 2025

✨ Benchmark results

  • Requests per second: 1,156
  • Requests with 200 status code: 208,161
  • P99 latency: 0.168785967

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,156 1,173
200 208,161 211,265
P99 0.168785967 0.179337659

@lohanidamodar lohanidamodar merged commit e85079a into 1.8.x Dec 10, 2025
40 checks passed
@lohanidamodar lohanidamodar deleted the fix-remove-temp-fix branch December 10, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants