Skip to content

Fix webp upload and previews #10738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: 1.8.x
Choose a base branch
from
Draft

Fix webp upload and previews #10738

wants to merge 1 commit into from
+1 −3

Conversation

@stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Oct 30, 2025

What does this PR do?

Upgrade base image to version 0.10.5 ensuring libwebp is installed in the base image when imagemagick is installed so that imagemagick works with webp.

Fixes #10699

Test Plan

  • added test cases

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90
Upgrade base image to version 0.10.5
458100c 
Ensure libwebp is installed in the base image when imagemagick is installed so that imagemagick works with webp.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-webp-library

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libxml2 2.13.8-r0 CVE-2025-49794 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49796 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49795 HIGH
libxml2 2.13.8-r0 CVE-2025-6021 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH
stdlib 1.22.10 CVE-2025-47912 HIGH
stdlib 1.22.10 CVE-2025-58183 HIGH
stdlib 1.22.10 CVE-2025-58185 HIGH
stdlib 1.22.10 CVE-2025-58186 HIGH
stdlib 1.22.10 CVE-2025-58187 HIGH
stdlib 1.22.10 CVE-2025-58188 HIGH
stdlib 1.22.10 CVE-2025-58189 HIGH
stdlib 1.22.10 CVE-2025-61723 HIGH
stdlib 1.22.10 CVE-2025-61724 HIGH
stdlib 1.22.10 CVE-2025-61725 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@stnguyen90
Copy link
Contributor Author

stnguyen90 commented Oct 30, 2025

@copilot add 2 test cases in https://github.com/appwrite/appwrite/blob/main/tests/e2e/Services/Storage/StorageBase.php:

  1. upload a webp image and ensure viewing it works
  2. previewing a non-webp image successfully returns a webp image (as described by response header)

Copilot AI mentioned this pull request Oct 30, 2025
Open
7 tasks
Copy link
Contributor

Copilot AI commented Oct 30, 2025

@stnguyen90 I've opened a new pull request, #10739, to work on those changes. Once the pull request is ready, I'll request review from you.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

✨ Benchmark results

  • Requests per second: 1,193
  • Requests with 200 status code: 214,702
  • P99 latency: 0.162381407

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,193 1,211
200 214,702 218,092
P99 0.162381407 0.168693605

@stnguyen90 stnguyen90 linked an issue Nov 3, 2025 that may be closed by this pull request
WEBP images preview not working in 1.8.0 #10699
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WEBP images preview not working in 1.8.0

2 participants

@stnguyen90