Conversation
* pools , env setup * collections, db endpoints
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
✨ Benchmark results
⚡ Benchmark Comparison
|
* configs and default attributes + indexes * separate collection creation setup * fix -> database metadata fix on collection creation
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Collections/Create.php
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Collections/Create.php
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Collections/Indexes/Create.php
Outdated
Show resolved
Hide resolved
734909d to
75045ff
Compare
src/Appwrite/Platform/Modules/Databases/Http/Databases/Transactions/Update.php
Outdated
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Collections/Documents/Text/Create.php
Outdated
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Embeddings/Text/Create.php
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Embeddings/Text/Create.php
Outdated
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Embeddings/Text/Create.php
Outdated
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Embeddings/Text/Create.php
Outdated
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Embeddings/Text/Create.php
Outdated
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Embeddings/Text/Create.php
Outdated
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Embeddings/Text/Create.php
Outdated
Show resolved
Hide resolved
- Updated the Create.php file to streamline the embedding creation process by removing unnecessary authentication checks and simplifying the parameter structure. - Changed the parameter from 'documents' to 'texts' for clarity and adjusted the embedding model handling. - Modified the response model to include error handling for embedding generation. - Updated the Embedding response model to reflect changes in dimension naming and added error message handling. - Refactored VectorDBCollection model to replace 'dimensions' with 'dimension' for consistency across the codebase. - Adjusted all relevant tests to accommodate the new parameter names and response structures, ensuring comprehensive coverage for the updated functionality.
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Embeddings/Text/Create.php
Outdated
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Embeddings/Text/Create.php
Outdated
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Embeddings/Text/Create.php
Outdated
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Embeddings/Text/Create.php
Outdated
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Embeddings/Text/Create.php
Outdated
Show resolved
Hide resolved
src/Appwrite/Platform/Modules/Databases/Http/VectorDB/Collections/Documents/Create.php
Outdated
Show resolved
Hide resolved
* aadded error text metric
There was a problem hiding this comment.
What's the difference with UsageVectorDB?
There was a problem hiding this comment.
Saw that Database follows this 'UsageDatabase' and 'UsageDatabases'
So to keep consistent with Database
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist