src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php (4)

143-148: Nit: variable name typo ($booleamParam).

Use $booleanParam for clarity.

-        $booleanParams = ['async'];
-        foreach ($booleanParams as $booleamParam) {
-            if (!empty($$booleamParam) && !is_bool($$booleamParam)) {
-                $$booleamParam = $$booleamParam === "true" ? true : false;
-            }
-        }
+        $booleanParams = ['async'];
+        foreach ($booleanParams as $booleanParam) {
+            if (!empty($$booleanParam) && !is_bool($$booleanParam)) {
+                $$booleanParam = $$booleanParam === "true";
+            }
+        }

---

120-132: Optional: enforce no body for HEAD to match RFC semantics.

Pre-empt confusing behavior by rejecting bodies with HEAD.

         if (!is_null($scheduledAt)) {
             $validator = new DatetimeValidator(requireDateInFuture: true, precision: DateTimeValidator::PRECISION_MINUTES, offset: 60);
             if (!$validator->isValid($scheduledAt)) {
                 throw new Exception(Exception::GENERAL_BAD_REQUEST, 'Execution schedule must be a valid date, and at least 1 minute from now');
             }
         }
+
+        // Disallow body for HEAD requests
+        if (\strtoupper($method) === 'HEAD' && \strlen($body) > 0) {
+            throw new Exception(Exception::GENERAL_BAD_REQUEST, 'HEAD requests must not contain a body.');
+        }

---

60-62: Duplicate label('resourceType', ...) declaration.

Remove one to avoid confusion.

-            ->label('resourceType', RESOURCE_TYPE_FUNCTIONS)
-            ->label('event', 'functions.[functionId].executions.[executionId].create')
-            ->label('resourceType', RESOURCE_TYPE_FUNCTIONS)
+            ->label('resourceType', RESOURCE_TYPE_FUNCTIONS)
+            ->label('event', 'functions.[functionId].executions.[executionId].create')

---

100-119: Add a test for HEAD path end-to-end (sync and async).

Validate: param acceptance, executor receives method=HEAD, response body handling, and persistence of requestMethod in execution doc.

I can draft an integration test covering: createExecution with method=HEAD (async=false), assert persisted requestMethod=HEAD and responseBody handling; plus async scheduled flow.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: ItzNotABug
PR: appwrite/appwrite#9669
File: src/Appwrite/Utopia/Request/Filters/V19.php:56-71
Timestamp: 2025-05-03T05:58:34.294Z
Learning: According to the developer, wildcard select handling in V19 request filter is only needed for `listDocuments` operations, not for `getDocument` operations, despite the doc-block mentioning both.

tests/e2e/Services/Functions/FunctionsCustomServerTest.php (2)

928-939: Prevent test pollution: delete the HEAD execution if it’s persisted

If HEAD executions still persist, later assertions (e.g., listExecutions expecting total=1) will break. Clean up conditionally so the suite remains stable regardless of backend behavior.

Apply this diff just after the HEAD assertions:

         $this->assertEquals('completed', $execution['body']['status']);
         $this->assertEquals(200, $execution['body']['responseStatusCode']);
         $this->assertIsArray($execution['body']['responseHeaders']);
         $this->assertEmpty($execution['body']['responseBody']); // For head requests, response body is empty
+
+        // Cleanup to avoid inflating listExecutions totals if an execution document was created
+        $headExecutionId = $execution['body']['$id'] ?? null;
+        if (!empty($headExecutionId)) {
+            $this->client->call(
+                Client::METHOD_DELETE,
+                '/functions/' . $data['functionId'] . '/executions/' . $headExecutionId,
+                array_merge([
+                    'content-type' => 'application/json',
+                    'x-appwrite-project' => $this->getProject()['$id'],
+                ], $this->getHeaders()),
+                []
+            );
+        }

---

939-939: Capitalize HTTP method in comment

Use standard casing for HTTP verbs.

-        $this->assertEmpty($execution['body']['responseBody']); // For head requests, response body is empty
+        $this->assertEmpty($execution['body']['responseBody']); // For HEAD requests, response body is empty

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.