app/controllers/api/databases.php (1)

281-287: Bug: Incorrect parentheses break attribute type/filter validation

Both conditionals are currently evaluating the wrong expressions due to misplaced parentheses. They likely always evaluate truthy/falsy incorrectly and can reject valid updates or mask invalid ones.

Fix with:

-    if ($attribute->getAttribute(('type') !== $type)) {
+    if ($attribute->getAttribute('type') !== $type) {
         throw new Exception(Exception::ATTRIBUTE_TYPE_INVALID);
     }

-    if ($attribute->getAttribute('type') === Database::VAR_STRING && $attribute->getAttribute(('filter') !== $filter)) {
+    if ($attribute->getAttribute('type') === Database::VAR_STRING && $attribute->getAttribute('filter') !== $filter) {
         throw new Exception(Exception::ATTRIBUTE_TYPE_INVALID);
     }

Consider adding/adjusting tests that hit updateAttribute() with mismatched type and filter to prevent regressions.

app/controllers/api/databases.php (2)

4554-4557: Catching InvalidArgumentException and mapping to GENERAL_ARGUMENT_INVALID is correct. Consider preserving the exception chain.

Good addition; it standardizes 0-value increments as a client error (400). Minor nit: preserve the original exception as "previous" to aid debugging and logs.

Apply this diff:

-        } catch (InvalidArgumentException $e) {
-            throw new Exception(Exception::GENERAL_ARGUMENT_INVALID, $e->getMessage());
+        } catch (InvalidArgumentException $e) {
+            throw new Exception(Exception::GENERAL_ARGUMENT_INVALID, $e->getMessage(), previous: $e);
         }

---

4633-4636: Same improvement for decrement: keep the exception chain.

Symmetric handling is good. Keep the previous exception to aid diagnostics.

Apply this diff:

-        } catch (InvalidArgumentException $e) {
-            throw new Exception(Exception::GENERAL_ARGUMENT_INVALID, $e->getMessage());
+        } catch (InvalidArgumentException $e) {
+            throw new Exception(Exception::GENERAL_ARGUMENT_INVALID, $e->getMessage(), previous: $e);
         }

tests/e2e/Services/Databases/DatabasesBase.php (1)

5572-5581: Zero-increment test is good; consider asserting mapped error type (GENERAL_ARGUMENT_INVALID).

To make the test more robust against regression in exception mapping, assert the error type as well.

         $inc3 = $this->client->call(Client::METHOD_PATCH, "/databases/$databaseId/collections/$collectionId/documents/$docId/count/increment", array_merge([
             'content-type' => 'application/json',
             'x-appwrite-project' => $this->getProject()['$id'],
         ]), [
             'value' => 0
         ]);
         $this->assertEquals(400, $inc3['headers']['status-code']);
+        $this->assertEquals(Exception::GENERAL_ARGUMENT_INVALID, $inc3['body']['type']);

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro