Improve HPACKEncoding performance by ~2x#541
Merged
Merged
Conversation
fabianfett
changed the title
glbrntt
reviewed
Mar 10, 2026
Comment on lines
+776
to
+778
| guard self.utf8.count == to.utf8.count else { | ||
| return false | ||
| } |
Contributor
There was a problem hiding this comment.
Doesn't it make more sense to push this down into the func on the utf8 view?
Member
Author
There was a problem hiding this comment.
Don't ask me why, but this kills performance:
==================
NIOHPACKBenchmarks
==================
HPACKHeaderEncoding_APNS
╒══════════════════════════╤═══════════╤═══════════╤═══════════╤═══════════╤═══════════╤═══════════╤═══════════╤═══════════╕
│ Metric │ p0 │ p25 │ p50 │ p75 │ p90 │ p99 │ p100 │ Samples │
╞══════════════════════════╪═══════════╪═══════════╪═══════════╪═══════════╪═══════════╪═══════════╪═══════════╪═══════════╡
│ Instructions (K) * │ 46 │ 46 │ 46 │ 46 │ 46 │ 46 │ 46 │ 441 │
├──────────────────────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────┤
│ Malloc (total) * │ 0 │ 0 │ 0 │ 0 │ 0 │ 0 │ 0 │ 441 │
├──────────────────────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────┤
│ Time (wall clock) (ns) * │ 2134 │ 2216 │ 2241 │ 2265 │ 2292 │ 2388 │ 2737 │ 441 │
╘══════════════════════════╧═══════════╧═══════════╧═══════════╧═══════════╧═══════════╧═══════════╧═══════════╧═══════════╛
Member
Author
There was a problem hiding this comment.
I can just assume that this is about inlining thresholds.
Lukasa
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets use the benchmark in #540:
main:
this branch: