Move search context methods from webdriver and webelement to search_context - #461
Conversation
|
@KazuCocoa @mykola-mokhnach |
| Returns: | ||
| :obj:`list` of :obj:`appium.webdriver.webelement.WebElement` | ||
|
|
||
| :rtype: list of `MobileWebElement` |
There was a problem hiding this comment.
why rtype is set for some methods and is not set for others?
There was a problem hiding this comment.
For auto completion #404.
But I'll remove it if possible after check.
There was a problem hiding this comment.
Unfortunately it's necessary for auto completion in IDE.
There was a problem hiding this comment.
I mean can we add rtype to other method declarations to make it consistent?
There was a problem hiding this comment.
In my opinion, it's unnecessary. (it's confusing us though.)
Originally rtype is unnecessary since Returns: works for auto completion.
https://www.jetbrains.com/help/pycharm/type-syntax-for-docstrings.html
- reStructuredText(
rtype) / Google(Returns:) / and so on
But auto completion doesn't work with Returns: for find_element_xxx somehow.
So added rtype to only find_element_xxx.
Will add one comment to rtype in each class.
|
@ki4070ma Added some suggestions, but otherwise looks good |
ki4070ma
changed the title
| @@ -0,0 +1,43 @@ | |||
| #!/usr/bin/env python | |||
2 participants
For #336