Moving reset method from WebDriver to Applications - #399
Merged
Conversation
KazuCocoa
approved these changes
Jun 13, 2019
KazuCocoa
left a comment
KazuCocoa
left a comment
Member
There was a problem hiding this comment.
Failing tests are out of this code. We should make them stable
Collaborator
|
[Just memo] Although I re-ran CI and log was gone, this error is due to azure pipeline(like 'error occurs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Move reset(self) method from webdriver.py to applications.py
Types of changes
Details
This is in reference to #325 . Moved the reset app method from Webdriver.py to applications.py
Already test is added for this method in app_test.py