Use the same format for docstring - #395
Merged
Merged
Conversation
| in order to retrieve the actual process output. | ||
| Args: | ||
| kwargs: | ||
| `env`: Environment variables mapping. The default system environment, |
Contributor
There was a problem hiding this comment.
should argument types also be mentioned?
Contributor
There was a problem hiding this comment.
same comment to several docstrings below
KazuCocoa
reviewed
Jun 9, 2019
| No scale is applied by default. (Since Appium 1.10.0) | ||
| - pixelFormat: Output pixel format. Run `ffmpeg -pix_fmts` to list possible values. | ||
| For Quicktime compatibility, set to "yuv420p" along with videoType: "libx264". (Since Appium 1.12.0) | ||
| iOS Specific: |
Member
There was a problem hiding this comment.
Should we set as different indentation for the following parameters? (I'm not familiar with this format)
iOS xxx:
videoQuality (str): xxxxx
Collaborator
Author
There was a problem hiding this comment.
Thanks for your comments.
Moved iOS, Android to each description.
ki4070ma
commented
Jun 10, 2019
ki4070ma
commented
Jun 10, 2019
ki4070ma
commented
Jun 10, 2019
ki4070ma
commented
Jun 10, 2019
ki4070ma
commented
Jun 10, 2019
KazuCocoa
approved these changes
Jun 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #387