Repository navigation
fix poll_url in Python 3 - #370
Conversation
|
Thanks for doing this fix! I'm getting a new error, however. The join function used in this seems to be giving an error about mixing strings and bytes in path components. I'll put my pytest error output below, and I can give any extra information you may need! Edit: I fixed this issue by casting the module arg of the join to a string. Not sure if this is just a local issue for me, but glad it's working now. Thanks so much!
|
|
@johnkulovitz Please report this as a separate bug |
closes #369
httplibis available only in Python 2 environment.SImply, I replaced the http request checking with
PoolManager.I tested locally in both Python 2 and 3 env.
Added a simple test case to ensure it can load in both python 2 and 3 environments.