Skip to content

Resolve ci exception log on py37 - #362

Closed
ki4070ma wants to merge 1 commit into
appium:masterfrom
ki4070ma:fix-ci-exception
Closed

Resolve ci exception log on py37#362
ki4070ma wants to merge 1 commit into
appium:masterfrom
ki4070ma:fix-ci-exception

Conversation

@ki4070ma

@ki4070ma ki4070ma commented May 2, 2019

Copy link
Copy Markdown
Collaborator

@ki4070ma ki4070ma changed the title Resolve ci exception log Resolve ci exception log on py37 May 2, 2019
Comment thread ci-requirements-py3.txt
@@ -0,0 +1,2 @@
astroid==2.2.5
pylint==2.3.1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the version consider Python 2?

I wonder if pylint 2 claims errors which might break Python 2, but good for Python 3.

@ki4070ma ki4070ma May 2, 2019

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if pylint 2 claims errors which might break Python 2, but good for Python 3.

I can't say it won't happen.
Your point is that we should have the same pylint version for python2/3, right?

Since exception log is no impact to the results, we can upgrade those version when we drop python2 support in the future.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
We support both of them by one codebase.


btw, we have https://github.com/appium/python-client/blob/master/development.txt .
It refers to ci-requirements.txt. we should update here, too.

@ki4070ma

ki4070ma commented May 3, 2019

Copy link
Copy Markdown
Collaborator Author

Thanks for your comments. I agree with you.

btw, we have https://github.com/appium/python-client/blob/master/development.txt .
It refers to ci-requirements.txt. we should update here, too.

Thanks for this, too. I didn't care of it...

@ki4070ma ki4070ma closed this May 3, 2019
@ki4070ma
ki4070ma deleted the fix-ci-exception branch May 3, 2019 03:04
@ki4070ma ki4070ma mentioned this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants