Skip to content

Improve pytest - #284

Merged
KazuCocoa merged 4 commits into
appium:masterfrom
KazuCocoa:improve-pytest
Dec 5, 2018
Merged

KazuCocoa merged 4 commits into
appium:masterfrom
KazuCocoa:improve-pytest

Conversation

@KazuCocoa

Copy link
Copy Markdown
Member

A part of #283

  • Add test/pytest.ini to make the result simple
  • Add ios_w3c_driver to get a driver for iOS
  • Define base url and generating command URL method

Comment thread test/unit/webdriver/webdriver_test.py Outdated
"""Track how many commands defined for Android W3C"""
driver = android_w3c_driver()
# pylint: disable=W0212
assert len(driver.command_executor._commands.keys()) == 174

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it is an extra effort to always update this number when a new command is added/removed

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, I thought so. Will remove it

@KazuCocoa
KazuCocoa merged commit d5b8a1e into appium:master Dec 5, 2018
@KazuCocoa
KazuCocoa deleted the improve-pytest branch December 5, 2018 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants