Skip to content

Numerous fixes - #15

Merged
imurchie merged 2 commits into
appium:masterfrom
bayandin:fixes
May 7, 2014
Merged

imurchie merged 2 commits into
appium:masterfrom
bayandin:fixes

Conversation

@bayandin

@bayandin bayandin commented May 7, 2014

Copy link
Copy Markdown
Contributor
  • fix typos with context
  • fix comparison with None
  • remove unused imports
  • fix imports order (according to pep8)
  • style fixes (according to pep8)
  • another minor fixes

bayandin added 2 commits May 7, 2014 16:38
1. fix comparation with None
2. remove unused imports
3. fix imports order (according to pep8)
4. style fixes (according to pep8)
5. another minor fixes

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of the trailing comma?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quote from python's documentation: last trailing comma is optional but good style.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'm not convinced of the reasoning, but it doesn't affect anything here.

imurchie added a commit that referenced this pull request May 7, 2014
@imurchie
imurchie merged commit 59ba9ff into appium:master May 7, 2014
@imurchie

imurchie commented May 7, 2014

Copy link
Copy Markdown
Collaborator

Thanks!

@bayandin
bayandin deleted the fixes branch May 8, 2014 03:30
@jlipps

jlipps commented May 8, 2014

Copy link
Copy Markdown
Member

👍 for trailing comma!

@jlipps

jlipps commented May 8, 2014

Copy link
Copy Markdown
Member

Wonder if we want a PEP-8 linter as a travis build step for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants