Repository navigation
Numerous fixes - #15
Merged
Merged
Conversation
bayandin
commented
May 7, 2014
Contributor
- fix typos with context
- fix comparison with None
- remove unused imports
- fix imports order (according to pep8)
- style fixes (according to pep8)
- another minor fixes
1. fix comparation with None 2. remove unused imports 3. fix imports order (according to pep8) 4. style fixes (according to pep8) 5. another minor fixes
Collaborator
There was a problem hiding this comment.
What is the point of the trailing comma?
Contributor
Author
There was a problem hiding this comment.
Quote from python's documentation: last trailing comma is optional but good style.
Collaborator
There was a problem hiding this comment.
Ok. I'm not convinced of the reasoning, but it doesn't affect anything here.
Collaborator
|
Thanks! |
Member
|
👍 for trailing comma! |
Member
|
Wonder if we want a PEP-8 linter as a travis build step for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.