Repository navigation
Upgrade to Selenium 3.14.0 #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ | |
| import io.appium.java_client.touch.offset.PointOption; | ||
| import org.junit.Test; | ||
| import org.openqa.selenium.WebElement; | ||
| import org.openqa.selenium.internal.HasIdentity; | ||
| import org.openqa.selenium.remote.RemoteWebElement; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.HashMap; | ||
|
|
@@ -60,7 +60,7 @@ public void longPressOptionsShouldBuildProperly() { | |
| .withDuration(ofMillis(1)) | ||
| .build(); | ||
| final Map<String, Object> expectedOpts = new HashMap<>(); | ||
| expectedOpts.put("element", ((HasIdentity) DUMMY_ELEMENT).getId()); | ||
| expectedOpts.put("element", ((RemoteWebElement) DUMMY_ELEMENT).getId()); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. such cast is probably redundant if DUMMY_ELEMENT is already RemoteWebElement
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DUMMY_ELEMENT is declared as: I can change variable type to
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| expectedOpts.put("x", 0); | ||
| expectedOpts.put("y", 0); | ||
| expectedOpts.put("duration", 1L); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to revert that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue was fixed in Selenium: SeleniumHQ/selenium@550cd0c, so no reason to keep this workaround