Repository navigation
Upgrade to Selenium 3.14.0 - #992
Conversation
| public AppiumCommandExecutor(Map<String, CommandInfo> additionalCommands, | ||
| URL addressOfRemoteServer) { | ||
| this(additionalCommands, addressOfRemoteServer, new AppiumHttpClientFactory()); | ||
| this(additionalCommands, addressOfRemoteServer, HttpClient.Factory.createDefault()); |
There was a problem hiding this comment.
Any reason to revert that?
There was a problem hiding this comment.
The issue was fixed in Selenium: SeleniumHQ/selenium@550cd0c, so no reason to keep this workaround
| */ | ||
| public static Map.Entry<String, Map<String, ?>> replaceElementValueCommand( | ||
| HasIdentity hasIdentityObject, String value) { | ||
| RemoteWebElement hasIdentityObject, String value) { |
There was a problem hiding this comment.
is HasIdentity interface removed from the API? I anyway would prefer to have an interface/abstract entity here rather than a real class
There was a problem hiding this comment.
it's scheduled for deletion with no replacement (SeleniumHQ/selenium@3665dd7#diff-15f3fec0ac0daf8e622a9724f94246e4).
Selenium maintainers replaced HasIndentity with RemoteWebElement: SeleniumHQ/selenium@3665dd7#diff-ff3a05d3dabdcb64c0729823366f4b10. I tried to follow the same pattern.
There was a problem hiding this comment.
strange decision...
There was a problem hiding this comment.
@valfirst Can we rename the object to remoteWebElement?
| .build(); | ||
| final Map<String, Object> expectedOpts = new HashMap<>(); | ||
| expectedOpts.put("element", ((HasIdentity) DUMMY_ELEMENT).getId()); | ||
| expectedOpts.put("element", ((RemoteWebElement) DUMMY_ELEMENT).getId()); |
There was a problem hiding this comment.
such cast is probably redundant if DUMMY_ELEMENT is already RemoteWebElement
There was a problem hiding this comment.
DUMMY_ELEMENT is declared as:
private static final WebElement DUMMY_ELEMENT = new DummyElement();
I can change variable type to RemoteWebElement or DummyElement, but I need to revise the logic of other tests, because it could be done intentionally to cover some logic.
There was a problem hiding this comment.
io.appium.java_client.touch.offset.ElementOption#withElement contains type check and type casting logic, so it looks like such declaration is a way to test the method logic.
f35b94e to
58afd18
Compare
Change list
Upgrade to Selenium 3.14.0
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that apply