Skip to content

#242 fix #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TikhomirovSergey merged 8 commits into from
Jul 19, 2016
Merged

#242 fix #437

TikhomirovSergey merged 8 commits into from
Jul 19, 2016

Conversation

@TikhomirovSergey
Copy link
Contributor

@TikhomirovSergey TikhomirovSergey commented Jul 11, 2016 •
edited
Loading

Change list

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Motivation:

Is described at #242
Also there is no really new and interesting features since v3.1.0/v3.2.0

@TikhomirovSergey
Copy link
Contributor Author

TikhomirovSergey commented Jul 11, 2016

@SrinivasanTarget @bootstraponline could you review this PR?

@GiannisPapadakis @Simon-Kaz you are free to join the discussion :)

There is a PR proposed to Selenium: SeleniumHQ/selenium#1034.

@SrinivasanTarget SrinivasanTarget added this to the 4.1.0 milestone Jul 11, 2016
@SrinivasanTarget
Copy link
Member

SrinivasanTarget commented Jul 11, 2016

@TikhomirovSergey I like this PR 👍 esp. WIKI. Will review my best soon :)

@SrinivasanTarget
Copy link
Member

SrinivasanTarget commented Jul 11, 2016

@TikhomirovSergey Its nice to see @codacy-bot working in PR's.

@TikhomirovSergey
Copy link
Contributor Author

TikhomirovSergey commented Jul 11, 2016 •
edited
Loading

@SrinivasanTarget That cool. will fix code of tests soon.

@vikramvi
Copy link

vikramvi commented Jul 15, 2016

Is there a way to configure codacy-bot to stop complaining about particular kind of issue like in this PR ?

@saikrishna321
Copy link
Member

saikrishna321 commented Jul 15, 2016

@vikramvi why do anyone want to do that? This helps in quick code review and code quality right..

@TikhomirovSergey
Copy link
Contributor Author

TikhomirovSergey commented Jul 15, 2016

why do anyone want to do that? This helps in quick code review and code quality right.
Right

@vikramvi @saikrishna321 I'm and @SrinivasanTarget for clean code. I think is good. Soon we will use CI for the PR validation and it will complain about bugs or test errors. I think it is offtop.

What do you think about the proposed PR?

@TikhomirovSergey
#242 fix: Working out issues which were found by codecy.
77d9362 
Also:
- improvement of the WIKI chapter
- update to org.springframework spring-context v4.3.1.RELEASE
@SrinivasanTarget
Copy link
Member

SrinivasanTarget commented Jul 15, 2016

@TikhomirovSergey Awesome Codacy is Green now 👍

@TikhomirovSergey
#242 fix: The potential bug was fixed.
5c0a4fe 
It was found during the self-review.
@saikrishna321
Copy link
Member

saikrishna321 commented Jul 18, 2016

@TikhomirovSergey Wow .. this is real kool feature and would help a lot in reporting.

Thanks @TikhomirovSergey for working on this.

@TikhomirovSergey TikhomirovSergey merged commit 53bbff5 into appium:master Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@TikhomirovSergey @SrinivasanTarget @vikramvi @saikrishna321