Skip to content

Conversation

@TikhomirovSergey
Copy link
Contributor

No description provided.

@TikhomirovSergey TikhomirovSergey changed the title #108 #105 Refactor is going on. AppiumDriver is made abstract. #105. Act II. AppiumDriver is made abstract. Sep 24, 2014
@TikhomirovSergey
Copy link
Contributor Author

Change log:

  • AppiumDriver has become abstract. @Jonahss I got your point.
  • AndroidKeyCode has been moved to "android" pakcage
  • AndroidDriver implements FindsByAndroidUIAutomator. IOSDriver implements FindsByIosUIAutomation. AppiumDriver still implements FindsByAccessibilityId.
  • SELENDROID_PORT has been added to MobileCapabilityType
  • update to Selenium 2.43.1
  • Tests have been moved, so it is convenient to run tests for each platform

tests

  • Test coverage is increased. I have add AndroidAccessibilityTest and AndroidContextTest.

@TikhomirovSergey
Copy link
Contributor Author

Note!!! AndroidContextTest. There are

//TODO 

comments.
I think there is a bug. AndroidDriver can't be run with Selendroid and activity defined in capabilities.

@TikhomirovSergey TikhomirovSergey changed the title #105. Act II. AppiumDriver is made abstract. #105. Act II. AppiumDriver became abstract. Sep 24, 2014
@Jonahss
Copy link
Member

Jonahss commented Sep 24, 2014

Awesome work!
Aha, android activity capability and selendroid don't work? Can you create a github issue on the main Appium project?

@TikhomirovSergey
Copy link
Contributor Author

Yeah! It doesn't work. An issue is coming soon.

@TikhomirovSergey
Copy link
Contributor Author

appium/appium#3698

Let AndroidContextTest stay as it is until issue is resolved.

@Jonahss
Copy link
Member

Jonahss commented Sep 25, 2014

Oops, just found I never added my AppiumDriverTest to the repo... >.<

Jonahss added a commit that referenced this pull request Sep 25, 2014
@Jonahss Jonahss merged commit 8b012e9 into appium:interfacesRefactor Sep 25, 2014
@Jonahss
Copy link
Member

Jonahss commented Sep 25, 2014

So, the tests for java-client can be very lite. We don't really need to test appium functionality, just that the client sends the right requests, and is able to parse responses. So things like Context, only need to be tested once for AppiumDriver, rather than separately for ios and Android. I'll show you what I plan in a pull request tomorrow, for now, don't worry about it ^.^

@TikhomirovSergey
Copy link
Contributor Author

Thanks, @Jonahss! I am looking forward to seeing something interesting.

If you can please put your new commits by 14:00 (2 PM) (US, California). I can do something till
1:00 (1 AM) (Russia, St. Petersburg).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants