hide cmd window on Windows when running subprocess

JazzCore · JazzCore · commit c8a896c7ee34 · 2021-03-20T10:36:55.000+03:00
diff --git a/pdfkit/configuration.py b/pdfkit/configuration.py
@@ -17,8 +17,13 @@ def __init__(self, wkhtmltopdf='', meta_tag_prefix='pdfkit-', environ=''):
         try:
             if not self.wkhtmltopdf:
                 if sys.platform == 'win32':
+                    #hide cmd window
+                    startupinfo = subprocess.STARTUPINFO()
+                    startupinfo.dwFlags |= subprocess.STARTF_USESHOWWINDOW
+                    startupinfo.wShowWindow = subprocess.SW_HIDE
+
                     self.wkhtmltopdf = subprocess.Popen(
-                        ['where.exe', 'wkhtmltopdf'], stdout=subprocess.PIPE).communicate()[0]
+                        ['where.exe', 'wkhtmltopdf'], stdout=subprocess.PIPE, startupinfo=startupinfo).communicate()[0]
                 else:
                     self.wkhtmltopdf = subprocess.Popen(
                         ['which', 'wkhtmltopdf'], stdout=subprocess.PIPE).communicate()[0]
diff --git a/pdfkit/pdfkit.py b/pdfkit/pdfkit.py
@@ -154,13 +154,28 @@ def handle_error(exit_code, stderr):
     def to_pdf(self, path=None):
         args = self.command(path)
 
-        result = subprocess.Popen(
-            args,
-            stdin=subprocess.PIPE,
-            stdout=subprocess.PIPE,
-            stderr=subprocess.PIPE,
-            env=self.environ
-        )
+        if sys.platform == 'win32':
+            #hide cmd window
+            startupinfo = subprocess.STARTUPINFO()
+            startupinfo.dwFlags |= subprocess.STARTF_USESHOWWINDOW
+            startupinfo.wShowWindow = subprocess.SW_HIDE
+
+            result = subprocess.Popen(
+                args,
+                stdin=subprocess.PIPE,
+                stdout=subprocess.PIPE,
+                stderr=subprocess.PIPE,
+                env=self.environ,
+                startupinfo=startupinfo
+            )
+        else:
+            result = subprocess.Popen(
+                args,
+                stdin=subprocess.PIPE,
+                stdout=subprocess.PIPE,
+                stderr=subprocess.PIPE,
+                env=self.environ
+            )
 
         # If the source is a string then we will pipe it into wkhtmltopdf.
         # If we want to add custom CSS to file then we read input file to
