Skip to content

Conversation

@MaryamAdnan3
Copy link
Contributor

@MaryamAdnan3 MaryamAdnan3 commented May 2, 2025

What

This PR adds interface of PaginationDataManager which all pagination types implement.

Why

To have a common interface for all pagination types to implement.

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@MaryamAdnan3 MaryamAdnan3 added the enhancement New feature or request label May 2, 2025
@MaryamAdnan3 MaryamAdnan3 requested a review from sufyankhanrao May 2, 2025 10:16
@MaryamAdnan3 MaryamAdnan3 self-assigned this May 2, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2025

@sufyankhanrao
Copy link
Collaborator

Not required anymore as we are keeping the core-interfaces unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants