Skip to content

ci: use shared workflows and refactor them #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Oct 16, 2024
Merged

ci: use shared workflows and refactor them #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions .github/workflows/_check_docs_build.yaml
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions .github/workflows/_linting.yaml
View file
Open in desktop

This file was deleted.

5 changes: 3 additions & 2 deletions .github/workflows/_publish_to_pypi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
required: true
type: string

env:
PYTHON_VERSION: 3.12

jobs:
publish_to_pypi:
name: Publish to PyPI
Expand All @@ -17,8 +20,6 @@ jobs:
environment:
name: pypi
url: https://pypi.org/project/crawlee
env:
PYTHON_VERSION: 3.12

steps:
- name: Checkout repository
Expand Down
32 changes: 0 additions & 32 deletions .github/workflows/_type_checking.yaml
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions .github/workflows/_unit_tests.yaml
View file
Open in desktop

This file was deleted.

82 changes: 82 additions & 0 deletions .github/workflows/build_and_deploy_docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
name: Build and deploy docs

on:
push:
branches:
- master
workflow_dispatch:

env:
NODE_VERSION: 20
PYTHON_VERSION: 3.12

jobs:
build_and_deploy_docs:
environment:
name: github-pages
permissions:
contents: write
pages: write
id-token: write
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
token: ${{ secrets.APIFY_SERVICE_ACCOUNT_GITHUB_TOKEN }}

- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
cache: npm
cache-dependency-path: website/package-lock.json

- name: Install Node dependencies
run: |
npm install
npm update @apify/docs-theme
working-directory: ./website

# We do this as early as possible to prevent conflicts if someone else would push something in the meantime
- name: Commit the updated package.json and lockfile
run: |
git config user.name 'GitHub Actions'
git config user.email 'github-actions[bot]@users.noreply.github.com'
git add website/package.json
git add website/package-lock.json
git diff-index --quiet HEAD || git commit -m 'chore: Automatic docs theme update [skip ci]' || true
git push

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: ${{ env.PYTHON_VERSION }}

- name: Install Python dependencies
run: |
pipx install --python ${{ env.PYTHON_VERSION }} poetry
make install-dev

- name: Build generated API reference
run: make build-api-reference

- name: Build Docusaurus docs
run: make build-docs

- name: Set up GitHub Pages
uses: actions/configure-pages@v5

- name: Upload GitHub Pages artifact
uses: actions/upload-pages-artifact@v3
with:
path: ./website/build

- name: Deploy artifact to GitHub Pages
uses: actions/deploy-pages@v4

- name: Invalidate CloudFront cache
run: gh workflow run invalidate.yaml --repo apify/apify-docs-private
env:
GITHUB_TOKEN: ${{ secrets.APIFY_SERVICE_ACCOUNT_GITHUB_TOKEN }}
68 changes: 0 additions & 68 deletions .github/workflows/docs.yaml
View file
Open in desktop

This file was deleted.

34 changes: 15 additions & 19 deletions .github/workflows/run_code_checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,23 @@ name: Run code checks

on:
# Trigger code checks on opening a new pull request.
pull_request_target:

# Do not trigger code checks on push to the master branch, as they will be triggered
# by the release workflow.

# Trigger code checks on workflow call (e.g. from run release workflow).
workflow_call:
# Secrets are only made available to the integration tests job, with a manual approval
# step required for PRs from forks. This prevents their potential exposure.
pull_request:

jobs:
run_linting:
name: Run linting
uses: ./.github/workflows/_linting.yaml
lint_check:
name: Lint check
uses: apify/workflows/.github/workflows/python_lint_check.yaml@main

run_type_checking:
name: Run type checking
uses: ./.github/workflows/_type_checking.yaml
type_check:
name: Type check
uses: apify/workflows/.github/workflows/python_type_check.yaml@main

run_unit_tests:
name: Run unit tests
uses: ./.github/workflows/_unit_tests.yaml
unit_tests:
name: Unit tests
uses: apify/workflows/.github/workflows/python_unit_tests.yaml@main

check_docs_build:
name: Check docs build
uses: ./.github/workflows/_check_docs_build.yaml
docs_check:
name: Docs check
uses: apify/workflows/.github/workflows/python_docs_check.yaml@main
Loading