refactor: use DeprecationWarning instead of logger.warning#687
Open
refactor: use DeprecationWarning instead of logger.warning#687
Conversation
…params Replace logger.warning() calls with warnings.warn(DeprecationWarning) in RequestQueueClient and RequestQueueClientAsync batch_add_requests() for consistency with the rest of the codebase. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (20.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #687 +/- ##
==========================================
- Coverage 94.61% 94.57% -0.05%
==========================================
Files 45 45
Lines 4404 4403 -1
==========================================
- Hits 4167 4164 -3
- Misses 237 239 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logger.warning()withwarnings.warn(DeprecationWarning)for deprecated params inbatch_add_requests()(both sync and async) to match the pattern used inDatasetClient.download_items()DeprecationWarningis the Python standard — visible by default, caught bypytest -W error::DeprecationWarning, and filterable viawarnings.filterwarnings()loggingimport🤖 Generated with Claude Code