fix(hydra): handle string and null serialization groups in DocumentationNormalizer#7890
Open
Roemerdt wants to merge 4 commits intoapi-platform:4.3from
Open
fix(hydra): handle string and null serialization groups in DocumentationNormalizer#7890Roemerdt wants to merge 4 commits intoapi-platform:4.3from
Roemerdt wants to merge 4 commits intoapi-platform:4.3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocumentationNormalizer::getPropertyMetadataFactoryContextcrashes when serialization groups are defined as a string rather than an array, or when no normalization/denormalization context is set.Symfony's serializer supports string groups.
AbstractNormalizer::getGroups()casts scalars to arrays, and the Symfony docs demonstrate the following is possible'groups' => 'public_view'.Reproducer:
#[ApiResource( normalizationContext: ['groups' => 'read'], denormalizationContext: ['groups' => 'write'], )] class DragonTreasure { ... }Requesting the Hydra documentation endpoint produces:
Warning: foreach() argument must be of type array|object, string given(string groups passed toforeach)Warning: Trying to access array offset on null(when context isnull)Fix:
getNormalizationContext()/getDenormalizationContext()with?? []to handlenullcontextsAbstractNormalizer::getGroups()behaviour