fix: use JSON:API compliant conversion#7889
Open
elfin-sbreuers wants to merge 1 commit intoapi-platform:4.3from
Open
fix: use JSON:API compliant conversion#7889elfin-sbreuers wants to merge 1 commit intoapi-platform:4.3from
elfin-sbreuers wants to merge 1 commit intoapi-platform:4.3from
Conversation
Following recommendations from here https://jsonapi.org/format/#fetching-pagination while being close to the ways used internally in api-platform.
Member
|
I left a detailed response on #7888 explaining the situation. In short: the JSON:API spec is explicitly agnostic about pagination strategy — Hardcoding the mapping I don't think we should merge this as-is. Comment mostly generated with Claude. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following recommendations from here
https://jsonapi.org/format/#fetching-pagination
while being close to the ways used internally in api-platform.
===
This addresses some of the issues discussed in this issue.
Going forward, there are two possible approaches:
Depending on the chosen approach, the links section needs to be handled accordingly:
This ultimately comes down to a design decision based on the desired level of compatibility and consistency.