fix(pwa): bypass corepack download prompt and use node slim#2952
Open
alinceDev wants to merge 1 commit intoapi-platform:mainfrom
Open
fix(pwa): bypass corepack download prompt and use node slim#2952alinceDev wants to merge 1 commit intoapi-platform:mainfrom
alinceDev wants to merge 1 commit intoapi-platform:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cannot bypass the prompt "Corepack is about to download". I needed to add the ENV variable COREPACK_ENABLE_DOWNLOAD_PROMPT=0.
Maybe we can move also to node-slim.
And there's no need to download the latest pnpm here as we download the version required from the package.json.