Skip to content

Support overriding exposed database port numbmer #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toby-griffiths wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support overriding exposed database port numbmer #2840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compose.override.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ services:
database:
ports:
- target: 5432
published: 5432
published: ${DB_PORT:-5432}
Copy link
Member

@dunglas dunglas Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe DATABASE_PORT for consistency with DATABASE_URL?

By the way, we should also use this new variable in DATABASE_URL in .env, otherwise the user will have to also override DATABASE_URL.

protocol: tcp
###< doctrine/doctrine-bundle ###

Expand Down