Skip to content

Fix for issue 4560 #4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
junedchhipa merged 1 commit into from
Jul 20, 2024
Merged

Fix for issue 4560 #4576

junedchhipa merged 1 commit into from
Jul 20, 2024

Conversation

@rosco54
Copy link
Contributor

@rosco54 rosco54 commented Jul 19, 2024

Fix getMinYMaxY() handling of multiple Y values per X value that was broken sometime after revision 3.45.2 following changes to handle chart y axis autoscaling directly within this function.

Fixes #4560

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@rosco54
Fix getMinYMaxY() handling of multiple Y values per X value that was
b28d322 
broken sometime after revision 3.45.2 following changes to handle
chart y axis autoscaling directly within this function.
@rosco54 rosco54 changed the title Fix issue 4560 Fix for issue 4560 Jul 19, 2024
@rosco54 rosco54 marked this pull request as ready for review July 19, 2024 11:45
@junedchhipa junedchhipa merged commit 34b3a67 into apexcharts:main Jul 20, 2024
@rosco54 rosco54 deleted the Issue_4560 branch July 21, 2024 07:29
@samul-1 samul-1 mentioned this pull request Aug 12, 2024
Open
@engbaher77 engbaher77 mentioned this pull request Aug 12, 2024
Open
@Sheitak Sheitak mentioned this pull request Aug 12, 2024
Open
@sgkens sgkens mentioned this pull request Aug 12, 2024
Open
This was referenced Aug 13, 2024
Open
Open
Open
Open
Open
This was referenced Aug 20, 2024
Open
Open
Open
Open
Open
Open
Open
@engbaher77 engbaher77 mentioned this pull request Aug 27, 2024
Open
@Sheitak Sheitak mentioned this pull request Aug 27, 2024
Open
@samul-1 samul-1 mentioned this pull request Aug 27, 2024
Open
@Sheitak Sheitak mentioned this pull request Aug 28, 2024
Open
@Wiran-Larbi Wiran-Larbi mentioned this pull request Aug 28, 2024
Open
This was referenced Aug 29, 2024
Open
Open
This was referenced Sep 25, 2024
Open
Open
Open
@sandaru-madhubhashana sandaru-madhubhashana mentioned this pull request Sep 27, 2024
Open
@Sheitak Sheitak mentioned this pull request Sep 28, 2024
Open
@CharlesGuerrero14 CharlesGuerrero14 mentioned this pull request Sep 29, 2024
Open
@Sheitak Sheitak mentioned this pull request Sep 29, 2024
Open
@YuvrajKaushal YuvrajKaushal mentioned this pull request Sep 30, 2024
Open
This was referenced Sep 30, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 1, 2024
Open
@l0renz02017 l0renz02017 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 2, 2024
Open
Open
Open
Open
Open
@Wiran-Larbi Wiran-Larbi mentioned this pull request Oct 25, 2024
Open
@engbaher77 engbaher77 mentioned this pull request Oct 25, 2024
Open
@Sheitak Sheitak mentioned this pull request Oct 26, 2024
Open
@samul-1 samul-1 mentioned this pull request Oct 31, 2024
Open
@PaolaQ-I PaolaQ-I mentioned this pull request Nov 1, 2024
Open
@mflorezmejia mflorezmejia mentioned this pull request Nov 1, 2024
Open
@CharlesGuerrero14 CharlesGuerrero14 mentioned this pull request Nov 2, 2024
Open
@Sheitak Sheitak mentioned this pull request Nov 2, 2024
Open
@deployor deployor mentioned this pull request Nov 4, 2024
Open
@samul-1 samul-1 mentioned this pull request Nov 7, 2024
Open
@Wiran-Larbi Wiran-Larbi mentioned this pull request Nov 8, 2024
Open
@engbaher77 engbaher77 mentioned this pull request Nov 8, 2024
Open
@Sheitak Sheitak mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junedchhipa junedchhipa junedchhipa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Line Plot Y-range incorrect when series has multiple points with same x-value

2 participants

@rosco54 @junedchhipa