Adjust some type annotations for variadic functions (lstrojny#182)

joranvar · lstrojny · commit ca1fe68bf0eb · 2019-02-22T00:37:03.000+01:00
According to phpDocumentor (https://github.com/phpDocumentor/ReflectionDocBlock/blob/14f9edf1ae14d6ce417afb05a9ed37d7b3cc341e/tests/unit/DocBlock/Tags/ParamTest.php#L152-L168), variadic arguments can be annotated in the `type ...$parameter` style. This fixes some false positive 'PhanTypeMismatchArgument' messages in analyses with phan, which in the old situation expects each parameter to be an array.
diff --git a/src/Functional/Compose.php b/src/Functional/Compose.php
@@ -27,7 +27,7 @@
 /**
  * Return a new function that composes all functions in $functions into a single callable
  *
- * @param callable[] $functions
+ * @param callable ...$functions
  * @return callable
  * @todo Add callable typehint when HHVM supports use of typehints with variadic arguments
  * @see https://github.com/facebook/hhvm/issues/6954
diff --git a/src/Functional/PartialAny.php b/src/Functional/PartialAny.php
@@ -30,7 +30,7 @@
  * Use Functional\…, Functional\…() or Functional\placeholder() as a placeholder
  *
  * @param callable $callback
- * @param array $arguments
+ * @param mixed ...$arguments
  * @return callable
  */
 function partial_any(callable $callback, ...$arguments)

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`	`/**`
`28`	`28`	`* Return a new function that composes all functions in $functions into a single callable`
`29`	`29`	`*`
`30`		`- * @param callable[] $functions`
	`30`	`+ * @param callable ...$functions`
`31`	`31`	`* @return callable`
`32`	`32`	`* @todo Add callable typehint when HHVM supports use of typehints with variadic arguments`
`33`	`33`	`* @see https://github.com/facebook/hhvm/issues/6954`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`	`* Use Functional\…, Functional\…() or Functional\placeholder() as a placeholder`
`31`	`31`	`*`
`32`	`32`	`* @param callable $callback`
`33`		`- * @param array $arguments`
	`33`	`+ * @param mixed ...$arguments`
`34`	`34`	`* @return callable`
`35`	`35`	`*/`
`36`	`36`	`function partial_any(callable $callback, ...$arguments)`