[SPARK-58281][ML][CONNECT] Avoid parent overcounting in PipelineModel size estimates#57451
Open
zhengruifeng wants to merge 4 commits into
Open
[SPARK-58281][ML][CONNECT] Avoid parent overcounting in PipelineModel size estimates#57451zhengruifeng wants to merge 4 commits into
zhengruifeng wants to merge 4 commits into
Conversation
zhengruifeng
changed the title
zhengruifeng
marked this pull request as ready for review
July 23, 2026 02:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds a
PipelineModel.estimatedSizeoverride that sums model-stage estimates individually and directly estimates non-model transformer stages. This prevents a reflection walk of the complete pipeline object graph.Adds a regression test that fits a pipeline containing
StringIndexerand asserts its size estimate remains below 16 KiB.Why are the changes needed?
SPARK-57521 clears the top-level model parent before the default size walk. A copied
PipelineModelstill contains copied model stages whose estimator parents are retained, so a reflection walk can still reach shared Spark-session state. Estimating nested model stages independently applies their parentless-copy behavior at every model boundary.Does this PR introduce any user-facing change?
Yes. Pipeline model cache-size estimates no longer include shared state reachable through nested stage parents, preventing unnecessary cache overcounting.
How was this patch tested?
StringIndexerpipeline size-estimation regression test.JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64 build/sbt 'mllib/Test/compile'\n\n### Was this patch authored or co-authored using generative AI tooling?\n\nGenerated-by: Codex GPT-5