[SPARK-58278][ML][CONNECT] Estimate size of Univariate, ChiSq, Variance selector, and Imputer models#57447
Open
zhengruifeng wants to merge 3 commits into
Open
Conversation
zhengruifeng
changed the title
zhengruifeng
marked this pull request as ready for review
July 23, 2026 02:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds explicit
estimatedSizeimplementations forUnivariateFeatureSelectorModel,ChiSqSelectorModel,VarianceThresholdSelectorModel, andImputerModel. The selector models account for their selected-feature arrays; the Imputer model accounts for its column names and surrogate values.Each model is covered by a fitted-model regression test that asserts the estimate remains below 2 KiB.
Why are the changes needed?
The default reflection-based estimate can traverse substantially more state than the fitted model owns. Direct accounting keeps model-size estimation small, predictable, and focused on the learned state.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64 build/sbt 'mllib/Test/compile'\n\n### Was this patch authored or co-authored using generative AI tooling?\n\nGenerated-by: Codex GPT-5