Skip to content

Fix hook for Doctrine PDO class#76

Merged
jmjoy merged 6 commits intoapache:masterfrom
matikij:fix-hook-doctrine-class
May 20, 2023
Merged

Fix hook for Doctrine PDO class#76
jmjoy merged 6 commits intoapache:masterfrom
matikij:fix-hook-doctrine-class

Conversation

@matikij
Copy link
Contributor

@matikij matikij commented May 19, 2023

When using doctrine the return type of PDO->prepare is Doctrine\DBAL\Driver\PDO\Statement and the hook didn't work. Changed the if to a match statement and added a bunch of debug statements. Fixed a minor typo.

@wu-sheng wu-sheng requested a review from jmjoy May 19, 2023 00:07
@wu-sheng wu-sheng added the bug Something isn't working label May 19, 2023
@wu-sheng wu-sheng added this to the 0.6.0 milestone May 19, 2023
@jmjoy
Copy link
Member

jmjoy commented May 19, 2023

Please format the code with: cargo +nightly fmt --all

Copy link
Member

@jmjoy jmjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmjoy jmjoy merged commit ab64a20 into apache:master May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants