Add amqplib plugin for producer.#64
Conversation
|
Looking forward to supporting the swoole coroutine component as soon as possible. |
src/component.rs
Outdated
| pub const COMPONENT_PHP_PREDIS_ID: i32 = 8006; | ||
| pub const COMPONENT_PHP_MEMCACHED_ID: i32 = 20; | ||
| pub const COMPONENT_PHP_REDIS_ID: i32 = 7; | ||
| pub const COMPONENT_RABBITMQ_PRODUCER_ID: i32 = 52; |
There was a problem hiding this comment.
So, only the producer side? No consumer?
There was a problem hiding this comment.
The consumer plan will be added later (PHP is not very suitable as a consumer).
README.md
Outdated
| * [ ] [php-amqp](https://github.com/php-amqp/php-amqp) | ||
| * [ ] [php-rdkafka](https://github.com/arnaud-lb/php-rdkafka) | ||
| * [x] [predis](https://github.com/predis/predis) | ||
| * [x] [php-amqplib](https://github.com/php-amqplib/php-amqplib) |
There was a problem hiding this comment.
Do you think we need to put producer here?
| * [x] [php-amqplib](https://github.com/php-amqplib/php-amqplib) | |
| * [x] [php-amqplib](https://github.com/php-amqplib/php-amqplib) for Message Queuing Producer. |
There was a problem hiding this comment.
Also, you mentioned amqp here, but the component ID is rabbitmq-producer. Is only Rabbit MQ supported?
There was a problem hiding this comment.
I will update the README and doc later.
There was a problem hiding this comment.
Not only RabbitMQ supported, but I don't found the component ID about amqp protocol, the library php-amqplib is commonly used in message queues services which supports the amqp protocol.
There was a problem hiding this comment.
If you need a general type for amqp, you have to register it here, https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml
Also, you may need mapping to indicate it is a queue server(without a specific MQ type), or an icon for topology.
I don't use swoole frequently, but I found that swoole supports SWOOLE_HOOK_ALL, so can we reuse FPM ecological components? |
4 participants
try_get_sw_headermethod.