Skip to content

Avoid potential panic for logger.#54

Merged
wu-sheng merged 2 commits intoapache:masterfrom
jmjoy:log
Feb 11, 2023
Merged

Avoid potential panic for logger.#54
wu-sheng merged 2 commits intoapache:masterfrom
jmjoy:log

Conversation

@jmjoy
Copy link
Member

@jmjoy jmjoy commented Feb 10, 2023

Because tracing-appender may panic when it is created, such as permission denied, so remove it and create the log file by myself.

@jmjoy jmjoy added the bug Something isn't working label Feb 10, 2023
@jmjoy jmjoy added this to the 0.4.0 milestone Feb 10, 2023
@jmjoy jmjoy marked this pull request as ready for review February 11, 2023 03:03
@jmjoy jmjoy requested review from heyanlong and wu-sheng February 11, 2023 03:03
@wu-sheng wu-sheng merged commit 9fb087b into apache:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants