Skip to content

Add plugin for phpredis.#29

Merged
jmjoy merged 10 commits intoapache:masterfrom
jmjoy:phpredis
Nov 10, 2022
Merged

Add plugin for phpredis.#29
jmjoy merged 10 commits intoapache:masterfrom
jmjoy:phpredis

Conversation

@jmjoy
Copy link
Member

@jmjoy jmjoy commented Oct 27, 2022

No description provided.

@jmjoy jmjoy added the enhancement New feature or request label Oct 27, 2022
@jmjoy jmjoy added this to the 0.2.0 milestone Oct 27, 2022
@jmjoy jmjoy marked this pull request as ready for review November 7, 2022 01:45
@jmjoy jmjoy requested a review from heyanlong November 7, 2022 01:45
@wu-sheng
Copy link
Member

wu-sheng commented Nov 7, 2022

Are you going to implement most TODO plugins and run 0.2.0 release?

@jmjoy
Copy link
Member Author

jmjoy commented Nov 7, 2022

Are you going to implement most TODO plugins and run 0.2.0 release?

I think it is possible to release version 0.2.0. It has been a month since version 0.1.0 was released.

But I found a bug that needs to be fixed. I will submit it in the next PR.

@wu-sheng
Copy link
Member

wu-sheng commented Nov 7, 2022

Your call. I just realized there are a lot of changes made in one month.

@jmjoy
Copy link
Member Author

jmjoy commented Nov 9, 2022

@heyanlong Please review when you are free.

@heyanlong
Copy link
Member

@jmjoy Why used component ID 11000, based as my know the 11000 is rust component ID

@heyanlong
Copy link
Member

@jmjoy
Copy link
Member Author

jmjoy commented Nov 9, 2022

But I use COMPONENT_PHP_REDIS_ID, which is 7.

@heyanlong
Copy link
Member

@jmjoy
Copy link
Member Author

jmjoy commented Nov 9, 2022

My mistake, was fixed.

@wu-sheng
Copy link
Member

wu-sheng commented Nov 9, 2022

You could refer this doc, https://skywalking.apache.org/docs/main/next/en/setup/service-agent/virtual-cache/.
Make sure the tags existed, then you can see the cache metrics on the UI's virtual cache dashboard.

@jmjoy
Copy link
Member Author

jmjoy commented Nov 9, 2022

@wu-sheng
Copy link
Member

wu-sheng commented Nov 9, 2022

@pg-yang
Copy link
Member

pg-yang commented Nov 9, 2022

Sorry,I would fix doc tonight

heyanlong
heyanlong previously approved these changes Nov 10, 2022
@jmjoy jmjoy merged commit c550167 into apache:master Nov 10, 2022
@jmjoy jmjoy deleted the phpredis branch November 10, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants