Skip to content

Add swoole support.#19

Merged
jmjoy merged 10 commits intoapache:masterfrom
jmjoy:swoole
Oct 13, 2022
Merged

Add swoole support.#19
jmjoy merged 10 commits intoapache:masterfrom
jmjoy:swoole

Conversation

@jmjoy
Copy link
Member

@jmjoy jmjoy commented Oct 12, 2022

Swoole is a popular coroutine library in PHP, so it is better to support swoole.

@jmjoy jmjoy added the enhancement New feature or request label Oct 12, 2022
@jmjoy jmjoy added this to the 0.2.0 milestone Oct 12, 2022
@jmjoy jmjoy marked this pull request as ready for review October 13, 2022 06:04
@jmjoy jmjoy requested a review from heyanlong October 13, 2022 06:06
heyanlong
heyanlong approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@heyanlong heyanlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmjoy jmjoy merged commit 807d2b5 into apache:master Oct 13, 2022
@jmjoy jmjoy deleted the swoole branch October 13, 2022 10:05
@huangdijia
Copy link

huangdijia commented Mar 9, 2023

Coroutine\Http\Client
Coroutine\MySQL
Swoole\Coroutine\Http\Client
Coroutine\Redis

Is there a plan to support them?

@jmjoy
Copy link
Member Author

jmjoy commented Mar 10, 2023

Coroutine\Http\Client Coroutine\MySQL Swoole\Coroutine\Http\Client Coroutine\Redis

Is there a plan to support them?

Yes, but not now.

@heyanlong
Copy link
Member

heyanlong commented Mar 10, 2023

@huangdijia Please to use discussions to discussions instead of here.

@huangdijia
Copy link

huangdijia commented Mar 10, 2023

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heyanlong heyanlong heyanlong approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jmjoy @huangdijia @heyanlong