Conversation
3 tasks
Member
|
The link of doc file should be removed, because the PECL file with role doc will not be copied to build dir. Lines 66 to 68 in 737b4f6 |
Member
Author
|
Why needs LICENSE for build? |
Member
Actually, it is unnecessary. |
jmjoy
reviewed
Oct 12, 2022
| </notes> | ||
| <contents> | ||
| <dir name="/"> | ||
| {% for file in files %}<file role="src" name="{{ file.path }}" /> |
Member
There was a problem hiding this comment.
Why not just make role as an placeholder, instead of using filter?
Member
Author
There was a problem hiding this comment.
Use filters to improve code judgment.
Member
Author
|
@jmjoy Could you review it? |
jmjoy
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.