Refactor worker to standalone crate#118
Merged
wu-sheng merged 7 commits intoapache:masterfrom Aug 15, 2024
Merged
Conversation
wu-sheng
approved these changes
Aug 15, 2024
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
So, this agent could run separatedly in a new OS level process? All data needs to transport cross processes?
Member
Author
|
Yes, processes can optionally run separately. In fact, data is currently transmitted across processes, through unix domain socket, but the process is automatically started when the extension is initialized. Now it is set to be optionally started manually separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to add a separate skywalking php worker binary, for php-fpm under daemon to use, but the worker's functionality was too coupled, so I first refactored the worker into a separate crate.