Merged
Conversation
Member
|
What is this used about? |
Member
Author
|
For clients in other languages, the trusted CA root certificate will be automatically read by default for gRPC requests. For tonic, We need to add a feature to support this. |
Member
|
CI fails for some reason, you need to fix them first. Other parts, let's wait for @jmjoy |
Member
|
There are some issues with the source of PHP 8.2. Try again after a while? If it doesn't work, skip the CI of PHP 8.2 first. |
Member
|
The new dependency is under Apache-2.0 license, so file |
Member
|
I there notice file to be added. |
jmjoy
approved these changes
Jun 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
tls-rootsfeature for use of trusted ca certificate for client.