Add support for dameng(DM) JDBC URL format in URLParser#758
Merged
wu-sheng merged 8 commits intoapache:mainfrom Jun 10, 2025
Merged
Add support for dameng(DM) JDBC URL format in URLParser#758wu-sheng merged 8 commits intoapache:mainfrom
wu-sheng merged 8 commits intoapache:mainfrom
Conversation
Member
|
I think that although you added this parser, the DB connection must be managed by supported JDBC pooling. Right? |
wu-sheng
reviewed
Jun 9, 2025
...etwork/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Yes, because this is a standard JDBC driver, so using something like HikariCP is absolutely fine. |
Member
|
I don mean removing from doc. I mean in other PR, you could see there is a PR in UI repo. |
Contributor
Author
|
@wu-sheng |
wu-sheng
reviewed
Jun 9, 2025
Member
|
I mean you don't need this. https://github.com/apache/skywalking-booster-ui/pull/403/files |
This reverts commit 359f373.
Contributor
Author
|
Thanks a lot for the help 🙏! |
wu-sheng
reviewed
Jun 10, 2025
wu-sheng
changed the title
wu-sheng
changed the title
wu-sheng
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.