Add empty judgment for constructorInterceptPoint#732
Merged
wu-sheng merged 1 commit intoapache:mainfrom Nov 29, 2024
Merged
Conversation
wu-sheng
reviewed
Nov 29, 2024
Comment on lines
+115
to
+118
| String constructorInterceptor = constructorInterceptPoint.getConstructorInterceptor(); | ||
| if (StringUtil.isEmpty(constructorInterceptor)) { | ||
| throw new EnhanceException("no InstanceConstructorInterceptor define to enhance class " + enhanceOriginClassName); | ||
| } |
Member
There was a problem hiding this comment.
Someone added an intercept point but no interceptor? What happens if not check? It will still be an error.
Contributor
Author
There was a problem hiding this comment.
If ConstructorInterceptor is empty but there is no check, no error message during runtime, but the expected data cannot be obtained because it is not intercepted, so I want to add a check here to inform the user.
wu-sheng
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.