fix: shade async-profiler packages#727
Conversation
|
Could you post the screenshot of new binary package here? And, have you tested the feature again? Shading sometimes breaks the function. |
|
About the so files, are they able to move as well? |
The .so file has not been moved yet. I think it should not be possible to move the .so file because the async-profiler code gets the dynamic library path based on the following code |
lujiajing1126
left a comment
There was a problem hiding this comment.
It is a solution as long as you understand that shading in the agent package instead of agent-core will make it impossible to be used from other packages like plugins
Do you mean you prefer to move this(shade) into core module? I think plugins would not access this part of codes. |
I am OK with this one. |
|
@zhengziyi0117 Could you try that? |
9806c91
apm-sniffer/apm-agent-core/pom.xml
Outdated
| <exclude>org.checkerframework:checker-compat-qual:jar:</exclude> | ||
| <exclude>org.checkerframework:checker-qual:jar:</exclude> | ||
| <exclude>org.codehaus.mojo:animal-sniffer-annotations:jar:</exclude> | ||
| <!-- <exclude>tools.profiler:async-profiler:jar:</exclude>--> |

CHANGESlog.