Skip to content

RenameJDBI to JDBC#381

Merged
wu-sheng merged 2 commits intoapache:mainfrom
nisiyong:jdbc-typo
Nov 14, 2022
Merged

RenameJDBI to JDBC#381
wu-sheng merged 2 commits intoapache:mainfrom
nisiyong:jdbc-typo

Conversation

@nisiyong
Copy link
Contributor

Many spans named JDBI are confusing and I think we should correct that typo.

@wu-sheng
Copy link
Member

wu-sheng commented Nov 12, 2022

This is a legacy thing, rather than a typo.
We were following Open Tracing APIs, which declare this. I think it is fine to correct them, but you need to make sure all tests passed

@nisiyong nisiyong changed the title Correct typo JDBI to JDBC RenameJDBI to JDBC Nov 13, 2022
@nisiyong
Copy link
Contributor Author

This is a legacy thing, rather than a typo.

Thanks for your mention, and I have found that JDBI meaning. JDBC still will be easier to understand. All tests are passed, please take a look.

@wu-sheng
Copy link
Member

Oracle case is still failing.

@nisiyong
Copy link
Contributor Author

I checked the test case failed message, and I think this error is not related to this PR. Could you rerun the oracle-scenario?
image

@wu-sheng
Copy link
Member

I had re-runed twice. It keeps failure.

@nisiyong
Copy link
Contributor Author

I think I should create a PR at repo SkyAPM/java-plugin-extensions first because the oracle plugin is out of the official repo.

@wu-sheng
Copy link
Member

A new release of the Oracle plugin repo

https://github.com/SkyAPM/java-plugin-extensions/releases/tag/2.3.0

@nisiyong
Copy link
Contributor Author

The oracle-scenario test case runs successfully now.

@wu-sheng wu-sheng added this to the 8.14.0 milestone Nov 14, 2022
@wu-sheng wu-sheng merged commit bcbbc2b into apache:main Nov 14, 2022
@nisiyong nisiyong deleted the jdbc-typo branch November 14, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants