Skip to content

[ISSUE #96] Fix the memory leak in Message #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ifplusor merged 2 commits into from
Oct 12, 2020
Merged

[ISSUE #96] Fix the memory leak in Message #98

ifplusor merged 2 commits into from
Oct 12, 2020

Conversation

@ziyht
Copy link
Contributor

@ziyht ziyht commented Oct 12, 2020

What is the purpose of the change

#96 possible memory leak

Brief changelog

fix memleak for message created by cpp library not released in class Message

Verifying this change

[ISSUE #96]

it happens in our production environment，the memory kepped increasing during the app running, it may up to 10Gb after running several days

when fixed by this, it shows:

● qos_collector.service - qos_collector
   Loaded: loaded (/etc/systemd/system/qos_collector.service; enabled; vendor preset: disabled)
   Active: active (running) since Fri 2020-10-09 09:18:24 CST; 3 days ago
 Main PID: 31166 (python2.7)
   Memory: 143.6M
   CGroup: /system.slice/qos_collector.service
           └─31166 /usr/bin/python /data/home/qos/opt/qos_collector/src/app.py --dev

@ziyht
Merge pull request #1 from apache/master
400b810 
sync from source
@ziyht
fix memleak
eac5223 
fix memleak  for message created by cpp library not released in class Message
@ifplusor ifplusor changed the title fix a simple memleak [ISSUE #96] Fix the memory leak in Message Oct 12, 2020
@ifplusor ifplusor linked an issue Oct 12, 2020 that may be closed by this pull request
possible memory leak #96
Closed
@ifplusor ifplusor merged commit 58397dc into apache:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@messense messense messense approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

possible memory leak

3 participants

@ziyht @messense @ifplusor