docs: clarify same-city dual-site deployment considerations#10429
Open
Adi-Beker wants to merge 1 commit into
Open
docs: clarify same-city dual-site deployment considerations#10429Adi-Beker wants to merge 1 commit into
Adi-Beker wants to merge 1 commit into
Conversation
oss-sentinel-ai
approved these changes
Jun 8, 2026
oss-sentinel-ai
left a comment
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Review by github-manager-bot
Summary
This PR adds documentation clarifying same-city dual-site deployment considerations to docs/en/Deployment.md.
Findings
- [Info] docs/en/Deployment.md:5-10 — Clear and accurate guidance on failure-domain planning, quorum assumptions, and avoiding unsupported active-active expectations.
- [Info] The content correctly emphasizes the importance of:
- Explicit failure-domain planning
- Quorum and failover assumptions
- NameServer reachability from both sites
- Using controller-based or replicated HA modes for automatic failover
Suggestions
The documentation addition is well-written and addresses a common deployment confusion. No changes needed.
Verdict
✅ Approved — Valuable documentation improvement with accurate technical guidance.
Automated review by github-manager-bot
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10429 +/- ##
=============================================
- Coverage 48.04% 47.97% -0.07%
+ Complexity 13305 13288 -17
=============================================
Files 1377 1377
Lines 100613 100613
Branches 12992 12992
=============================================
- Hits 48341 48271 -70
- Misses 46354 46401 +47
- Partials 5918 5941 +23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #10427
Brief Description
This PR adds a short clarification to
docs/en/Deployment.mdabout same-city dual-site deployment considerations.The added note highlights failure-domain planning, quorum and failover assumptions, NameServer reachability, replicated Broker groups, and avoiding unsupported active-active expectations.
How Did You Test This Change?
Documentation-only change.